Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve pagination #96

Merged
merged 6 commits into from
Nov 7, 2017
Merged

fix: Improve pagination #96

merged 6 commits into from
Nov 7, 2017

Commits on Nov 6, 2017

  1. fix: updated pagination to rely on core struct

    - first pass complete
      - Limit and Offset ListParams obtained by api/handlers' List functions/methods using `ListParamsFromRequest()`
      - `params_test.go` added, handles a few cases of invalid limits and offsets
    - partially complete
    - added support for accepting an 'orderBy' request query param just now but have not yet updated core/params_test and api/handlers functions to use this value yet
    Thomas Osterbind committed Nov 6, 2017
    Configuration menu
    Copy the full SHA
    cdba451 View commit details
    Browse the repository at this point in the history
  2. fix: updated handlers functions taking a ListParams to use the OrderB…

    …y field
    Thomas Osterbind committed Nov 6, 2017
    Configuration menu
    Copy the full SHA
    1bf6ec3 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2017

  1. style: ammended pagination update and changed default ListParams.OrderBy

    - cleaned up and deleted commented-out commented out lines added in previous pagination commit
    - added ListParams `Page()` method
    - updated core/params and core/params to no longer assume a default value of 'created'
    -
    Thomas Osterbind committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    36fb0ac View commit details
    Browse the repository at this point in the history
  2. style: ammended pagination update and changed default ListParams.OrderBy

    - cleaned up and deleted commented-out lines that were added in previous pagination commit
    - added ListParams `Page()` method
    - updated core/params and core/params to no longer assume a default value of 'created'
    Thomas Osterbind committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    a10eea0 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'improve_pagination' of https://github.com/qri-io/qri in…

    …to improve_pagination
    Thomas Osterbind committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    3a5bb64 View commit details
    Browse the repository at this point in the history
  4. style: moved calls to args.Page() from a variable assignment to an …

    …inline expression
    Thomas Osterbind committed Nov 7, 2017
    Configuration menu
    Copy the full SHA
    b0a335e View commit details
    Browse the repository at this point in the history