Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4650][ADD] stock_valuation_layer_view_adjust #92

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from

Conversation

AungKoKoLin1997
Copy link
Contributor

@AungKoKoLin1997 AungKoKoLin1997 commented Aug 28, 2024

optional is not working in SVL tree view. May be because of it's js. So, I didn't add this attribute in this PR.
4650

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-stock_valuation_layer_view_adjust branch from 6b09905 to ea7c65e Compare August 28, 2024 10:19
Comment on lines 1 to 2
This module displays remaining_qty and remaining_value in the SVL tree
view.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This module displays remaining_qty and remaining_value in the SVL tree
view.
This module displays remaining_qty and remaining_value in the SVL views.

<field name="inherit_id" ref="stock_account.stock_valuation_layer_tree" />
<field name="arch" type="xml">
<field name="value" position="after">
<field name="remaining_qty" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please comment why we are not adding optional="show" here.

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-stock_valuation_layer_view_adjust branch from 57bca95 to dfd1098 Compare August 29, 2024 02:07
@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 16.0-add-stock_valuation_layer_view_adjust branch from dfd1098 to 5cffe1e Compare August 29, 2024 02:11
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

@yostashiro yostashiro assigned yostashiro and kanda999 and unassigned yostashiro Aug 29, 2024
@yostashiro
Copy link
Member

@AungKoKoLin1997 I have added optional="show" to the columns, and it seems to be working as expected in my devel database and test databases (there is actually no reason not to add it even if it doesn't work for some glitches as long as it doesn't have a negative effect).

Can you please revisit odoo/odoo#178161 as necessary?

@AungKoKoLin1997
Copy link
Contributor Author

@yostashiro I have checked the latest code with latest odoo with the new test database. But it is still not working as expected.
Screenshot 2024-09-19 at 09 33 15

Screenshot 2024-09-19 at 09 32 49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants