Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4840][ADD] commission_settlement_commission #150

Merged
merged 2 commits into from
Oct 15, 2024
Merged

[4840][ADD] commission_settlement_commission #150

merged 2 commits into from
Oct 15, 2024

Conversation

AungKoKoLin1997
Copy link
Contributor

yostashiro
yostashiro approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review.

yostashiro
yostashiro reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I suggest a different name for the module: commission_settlement_commission

@AungKoKoLin1997 AungKoKoLin1997 force-pushed the 15.0-add-settlement_commission branch from 6f6cd09 to c4a73a0 Compare October 11, 2024 02:09
@AungKoKoLin1997 AungKoKoLin1997 changed the title [4840][ADD] settlement_commission [4840][ADD] commissionsettlement_commission Oct 11, 2024
@AungKoKoLin1997 AungKoKoLin1997 changed the title [4840][ADD] commissionsettlement_commission [4840][ADD] commission_settlement_commission Oct 11, 2024
kanda999
kanda999 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@kanda999 kanda999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and Functional review

@kanda999 kanda999 merged commit baeca6e into 15.0 Oct 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kanda999 kanda999 kanda999 approved these changes

@yostashiro yostashiro yostashiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AungKoKoLin1997 @yostashiro @kanda999