Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Documentation authEndpoint is required #67

Closed
wants to merge 1 commit into from
Closed

Fix Documentation authEndpoint is required #67

wants to merge 1 commit into from

Conversation

glwbr
Copy link

@glwbr glwbr commented May 25, 2024 •
edited
Loading

If the option is given, then authEndpoint is actually required.

@glwbr
Fix Documentation
b5f7e5e 
That ```authEndpoint``` is actually required.
@slavarazum
Copy link
Contributor

https://github.com/qruto/laravel-wave-client/blob/main/src/wave-broadcaster.ts#L21

As you can see, options merges with appropriate order, so authEndpoint has default value.

Do you have any specific issue with this?

@glwbr
Copy link
Author

glwbr commented Jun 4, 2024 •
edited
Loading

@slavarazum Not a problem, It's that if you pass the options to new Wave() you'd also have to pass authEndpoint but right now the README says it's optional:
Example

@slavarazum
Copy link
Contributor

Oh, yes! It was previously marked as required in the client library, but it is now optional. client release

Thanks for participating 🤝

@slavarazum slavarazum closed this Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@glwbr @slavarazum