Skip to content
This repository has been archived by the owner on Aug 19, 2024. It is now read-only.

Fixed most ruff violations in the libtorrent folder #26

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

qstokkink
Copy link
Owner

@qstokkink qstokkink commented Apr 23, 2024

Fixes #23

This PR:

  • Fixes most of the ruff linting errors in the src/tribler/core/libtorrent directory.

Notes:

  • Some violations remain. However, I would like to have a type-checker active before touching those.
  • Types may still be incorrect (see previous point).
  • Some violations are ignored (noqa: ...) because I consider them O.K. for now but we can look at our ignores in the future.

@qstokkink qstokkink marked this pull request as ready for review April 23, 2024 12:35
@qstokkink qstokkink changed the title WIP: Fixed most ruff violations in the libtorrent folder READY: Fixed most ruff violations in the libtorrent folder Apr 23, 2024
Copy link
Collaborator

@xoriole xoriole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qstokkink qstokkink changed the title READY: Fixed most ruff violations in the libtorrent folder Fixed most ruff violations in the libtorrent folder Apr 23, 2024
@qstokkink qstokkink merged commit 5f71463 into highlander Apr 23, 2024
3 of 4 checks passed
@qstokkink qstokkink deleted the fix_libtorrent_ruff branch April 23, 2024 12:39
@qstokkink qstokkink mentioned this pull request Apr 29, 2024
11 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E-mail lipu
2 participants