Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.6 #3

Closed
wants to merge 26 commits into from
Closed

5.6 #3

wants to merge 26 commits into from

Commits on Nov 28, 2016

  1. Bump version

    Change-Id: I9ee9754d3464f0cf33718267535ba6d054bbea10
    ossilator committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    2c6bd45 View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2017

  1. Fix crash when C++ QJSValue parameterized signal interacts with JS

    When converting the parameters of a C++ signal to JS values to provide
    to a signal handler written in JS, the conversion of a QJSValue to a
    QV4::Value* may yield a null pointer in case of a default constructed
    QJSValue for example. This is a regression from commit
    aa869cb and we must check for this.
    
    Task-number: QTBUG-58133
    Change-Id: I528b606b2851dfb3072e54902bd8843d31571a55
    Reviewed-by: Lars Knoll <lars.knoll@qt.io>
    (cherry picked from commit 0e3380f)
    tronical committed Jan 14, 2017
    Configuration menu
    Copy the full SHA
    600951e View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2017

  1. Accept PUA characters, ZWNJ and ZWJ as input in TextInput/Edit

    Private Use Area characters are quite valid input characters when used
    in combination with a custom font. Joiners also serve an important language
    purpose in semitic writing systems.
    
    [ChangeLog][QtWidgets][Input] Support characters in Private Use Area, as well as
    zero-width joiners and zero-width non-joiners in input in TextInput and TextEdit.
    
    Task-number: QTBUG-42074
    Task-number: QTBUG-57003
    Change-Id: I62bcd2ab0784f7f731921fbcdd8c695c02b165e4
    (cherry picked from commit 97e4d5d)
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    eskilblomfeldt authored and tronical committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    dc5efbf View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2017

  1. Fix support for QJSValue as C++ signal parameter type, part 2

    After commit 0e3380f we wouldn't crash
    anymore, if QJSValue::UndefinedValue was provided as value for a
    QJSValue C++ signal parameter. However that was not a complete fix for
    the regression of commit aa869cb, as
    other primitive values stored in QJSValue as QVariant were not
    converted, so for example QJSValue(42). So let's fix this once and for
    all by using QJSValuePrivate::valueForData, that handles all types of
    QJSValuePrivate encodings.
    
    Task-number: QTBUG-58133
    Change-Id: Ib7c0461b18df6260ccd4bce729ae2348281eb7f3
    Reviewed-by: Arnaud Vrac <avrac@freebox.fr>
    Reviewed-by: Lars Knoll <lars.knoll@qt.io>
    (cherry picked from commit 89c6bee)
    tronical committed Jan 19, 2017
    Configuration menu
    Copy the full SHA
    533f959 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2017

  1. Enable PropertyChanges to correctly restore binding on alias

    Change-Id: I88ffdd1d1224705e980e449b6c799c9f186143b1
    Task-number: QTBUG-58271
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit 22b03fd)
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    mbrasser-ford authored and tronical committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    89f8c55 View commit details
    Browse the repository at this point in the history
  2. Fix memory leak in V4

    Transitions contain both an id and a set of flags, but the sorting
    failed to take the flags into account in the operator<. As a result
    we would some times end up with duplicate entries if the same id
    was added multiple times with different flags.
    
    If the same id was added again and again with varying flags, this
    could lead to an ever expanding list filled with duplicate entries.
    
    Fix this by also taking flags into account in operator< so that
    operator< and operator== are symetric and the list gets correctly
    sorted.
    
    Change-Id: I6d55c67083e4a09e3eb2952edbec302389421f33
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    (cherry picked from commit 94324a4)
    sletta authored and tronical committed Feb 3, 2017
    Configuration menu
    Copy the full SHA
    cdbda2e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2017

  1. QtQuick scene graph: fix text native rendering

    Only 65536 vertices (65536 / 4 = 16384 characters) can be drawn in one
    draw call. This is why QSGDistanceFieldGlyphNode (renderType:
    Text.QtRendering) creates subnodes if number of characters exceeds that
    limit. QSGDefaultGlyphNode (renderType: Text.NativeRendering) missed
    that logic for some reason.
    
    Task-number: QTBUG-58852
    Change-Id: I88b3fcdb8e56bc92622d3347cd638634d43df138
    Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
    (cherry picked from commit 42e098f)
    Oleg Yadrov committed Mar 13, 2017
    Configuration menu
    Copy the full SHA
    8e26ddf View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2017

  1. Fix build with GCC 7

    GCC 7 warns about preprocessor macros expanding to defined(),
    which the masm config macros use pervasively.
    
    Fix by suppressing the warning (-Wexpansion-to-defined).
    
    Task-number: QTBUG-59647
    Change-Id: I9220741cf594824472bffc2305b994b311e55832
    Reviewed-by: Lars Knoll <lars.knoll@qt.io>
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit 29bf17d)
    marc-kdab committed Mar 22, 2017
    Configuration menu
    Copy the full SHA
    be66de8 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2017

  1. Prospective fix for static builds on Windows with QtQuickCompiler

    Don't define QML_PARSER_EXPORT to dllimport when doing static builds.
    
    Task-number: QTBUG-59767
    Change-Id: I24acb2c51f54a0cde8d2e50a935ede876e5eb5b7
    Reviewed-by: Andy Shaw <andy.shaw@qt.io>
    (cherry picked from commit 3caf24c)
    tronical committed Apr 3, 2017
    Configuration menu
    Copy the full SHA
    aebb0f6 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2017

  1. Fix for dangling object pointers in QQmlErrors

    This rarely happens - only seen with Delegates - when
     - an object is created during incubation
     - some error occurs in this object
     - the object gets deleted before the incubation run finishes
    Because the errors are delivered after the incubation run finished, the
    object() pointer of QQmlError is now a dangling pointer that will crash
    your application if accessed.
    
    Change-Id: Idd9fccbc58e4ada67bde3ca1aeec736aa9374789
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit 6a8a7e6)
    Robert Griebl authored and tronical committed Apr 19, 2017
    Configuration menu
    Copy the full SHA
    f76dd50 View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2017

  1. QML: clear the property cache on QObjectWrapper destuction

    If an external QObject is exposed to an engine through a QObjectWrapper,
    make sure to deref and clear the propertyCache reference in the object's
    declarative data when the QObjectWrapper is destroyed. This makes sure
    that there is no dangling propertyCache pointer when the object is
    subsequently exposed to another engine.
    
    Task-number: QTBUG-57633
    Change-Id: I37f6793d8be65b23b4e81bb4ed91db18271261b0
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit 749a721)
    Erik Verbruggen authored and tronical committed Apr 26, 2017
    Configuration menu
    Copy the full SHA
    2da8e40 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2017

  1. Fixed assertion failure when using QSG_RENDERER_DEBUG=upload

    Added a check that Batch::drawSets is not empty.
    
    Task-number: QTBUG-48439
    Change-Id: Ica76363be8c770240dc69c669815a60904e26988
    Reviewed-by: Gunnar Sletta <gunnar@sletta.org>
    (cherry picked from commit 893a4ff)
    Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
    Reviewed-by: Jason Erb (Suitable Technologies) <erb@suitabletech.com>
    Jason Erb committed May 4, 2017
    Configuration menu
    Copy the full SHA
    ab92855 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2017

  1. Remove outdated QJSValue benchmark

    Now that the oterh QJSValue benchmark is fixed (yes, there were two
    benchmarks with the same name), this benchmark is superfluous.
    
    Change-Id: I39a7f9cc79dccef8aac3d4c3999a3d75e1b1aa3d
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    (cherry picked from commit 448104e)
    Erik Verbruggen authored and tronical committed May 9, 2017
    Configuration menu
    Copy the full SHA
    d6f5732 View commit details
    Browse the repository at this point in the history
  2. Fix a QJSValue benchmark

    The benchmark added the tst_QJSValue instance driving the benchmark to
    the engine, which then takes over ownership. This would result in a
    use-after-free, leading to a crash.
    
    Change-Id: I524445487a1dabb3fb3fbbfb7fca084f7736c124
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    (cherry picked from commit 365d43a)
    Erik Verbruggen authored and tronical committed May 9, 2017
    Configuration menu
    Copy the full SHA
    babfbe2 View commit details
    Browse the repository at this point in the history
  3. QQmlComponent: Fix heap buffer overflow with bogus input

    (cherry picked from commit 30dbe57)
    Change-Id: I20a030ddba6ae42b9959473fe68e622c6a42a8bf
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    Peter Hartmann committed May 9, 2017
    Configuration menu
    Copy the full SHA
    bd782de View commit details
    Browse the repository at this point in the history

Commits on May 10, 2017

  1. Make sure we cannot reload debug connectors on shutdown

    The various Q_GLOBAL_STATICs involved in the loading of debug plugins
    may be destroyed in any order. If the connector is unloaded before the
    services, it might get reloaded when one service calls instance(),
    trying to de-register itself. Prevent this by clearing all the
    parameters.
    
    Change-Id: If0df8e7086e7e2a4d8701f61addd8c4a661aa349
    Reviewed-by: hjk <hjk@qt.io>
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit fca6857)
    Ulf Hermann committed May 10, 2017
    Configuration menu
    Copy the full SHA
    bae65d8 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2017

  1. Fix benchmark: remove benchmarks containing old v8 references

    The removed benchmarks don't make sense anymore: they were testing the
    QQmlEngine part, while another test was doing the QJSEngine. These days
    the QQmlEngine is a subclass of the QJSEngine and the test would call
    the QJSEngine (which, as said, was already done in another benchmark).
    
    Change-Id: Id1982dc118c399938a2dca8fb3c0a733e52fb20e
    Reviewed-by: Lars Knoll <lars.knoll@qt.io>
    (cherry picked from commit 9abcbbd)
    Erik Verbruggen committed May 12, 2017
    Configuration menu
    Copy the full SHA
    f3c87d2 View commit details
    Browse the repository at this point in the history
  2. Fix qml file loading for tst_affectors

    Change-Id: Ifb1b6f6d71d42c1642167725526c054f1dce0c90
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    (cherry picked from commit 9064d07)
    Erik Verbruggen committed May 12, 2017
    Configuration menu
    Copy the full SHA
    2215227 View commit details
    Browse the repository at this point in the history
  3. Disable particle benchmarks

    They are broken. See QTBUG-60621 for details.
    
    Task-number: QTBUG-60621
    Change-Id: Ibf55c64ef1b367bc2058d1c2284cd378ffa826ec
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    (cherry picked from commit 23a3018)
    Erik Verbruggen committed May 12, 2017
    Configuration menu
    Copy the full SHA
    fdf8daa View commit details
    Browse the repository at this point in the history
  4. Another benchmark fix

    Again JS ownership, now shown as an attempt to free a non-malloced
    pointer.
    
    Change-Id: I00a9b1e4918da96aa5bc99a321edc94d76c4f45b
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit 63f0406)
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    Erik Verbruggen committed May 12, 2017
    Configuration menu
    Copy the full SHA
    98af9f4 View commit details
    Browse the repository at this point in the history
  5. Fix build of animation benchmark

    This was using symbols exported only by a developer build.
    
    Change-Id: If2e80a7f7831366a23c5c52669915385cfb3e7c6
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit 720a88b)
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    Erik Verbruggen committed May 12, 2017
    Configuration menu
    Copy the full SHA
    2a9fd3d View commit details
    Browse the repository at this point in the history

Commits on May 16, 2017

  1. Fix wrong grabbing behavior

    QQuickWidget::grabFrameBuffer() was not polishing its items nor
    syncing the scene graph compared to standard QQuickWindow::grabWindow().
    This lead to QQuickWidget grabbed content to be outdated (render
    the previous frame as a new frame).
    
    Task-number: QTBUG-57596
    Change-Id: I0a2eff0c4f84cfd432f60f9d2fc41ac6a723fa5e
    Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
    Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
    (cherry picked from commit 0d243a8)
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    pasnox committed May 16, 2017
    Configuration menu
    Copy the full SHA
    caa273e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2017

  1. Don't leak QQmlJavaScriptExpression errors

    Ensure any error is deleted when the expression is
    
    Change-Id: Ibbfd28f50279d4c66830b40c5c917eb8d98f266e
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    (cherry picked from commit 1e06851)
    cogilvie authored and tronical committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    bd53456 View commit details
    Browse the repository at this point in the history
  2. Fix bug in designer support reference counting

    The QtQuick designer support may override the meta-object and reparent the
    property-cache of the object under editing. The code for replacing the parent
    of the property cache however was not handling the refcount of the _parent
    correctly.
    
    Change-Id: Ic73294fc208b297e8ec9c0b775b5da01a309dba6
    Reviewed-by: Robin Burchell <robin.burchell@viroteck.net>
    (cherry picked from commit 7dc5cd9)
    Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
    tronical committed Jul 27, 2017
    Configuration menu
    Copy the full SHA
    7ed7f10 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2017

  1. Fix crash in QQuickAnimatedImage

    Check d->_movie pointer before dereferencing
    
    Task-number: QTBUG-62380
    Change-Id: I62314c7c0d4a7e41fa6f8c4629d16f30d6036156
    Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
    Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
    Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
    (cherry-picked from fc3ecd2)
    a-ilin authored and ec1oud committed Aug 15, 2017
    Configuration menu
    Copy the full SHA
    f724b53 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2017

  1. Don't crash: Connections with a signal on a nonexistent object

    Task-number: QTBUG-56551
    Change-Id: Ide09f177d3f6a3e9902f8ea904b3e6e4b998bd39
    Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
    (cherry picked from commit 02830aa)
    Reviewed-by: Lars Knoll <lars.knoll@qt.io>
    ec1oud authored and tronical committed Aug 31, 2017
    Configuration menu
    Copy the full SHA
    59b726e View commit details
    Browse the repository at this point in the history