Attempt webhook #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 4, 2021 22:07
- Switched from thephpleague/omnipay-mollie to mollie/mollie-api-php - Created a webhook that Mollie will call when a payment status change occurs Issues: For some reason, sometimes at line 114, changePaymentState is unable to locate the order using the Mollie payment id that was sent to the webhook, causing $order to be null and being unable to create a new PaymentResult instance on line 119.
- Changed plugin name to better reflect it's purpose - Re-added missing composer.json content - Removed obsolete - Added ability to change order status to 'canceled' when the Mollie payment is canceled. Issues: - Using $this->order->total_in_currency for the payment amount does not work when the total amount is a round number like 200 because the Mollie API expects "200.00". Need to find a safe and reliable way to convert this.
- The plugin now has the ability to specify a Mollie payment method when creating a payment. When creating a payment method in the "Mall: Payments" section of the settings, make sure that the "Code" field matches a [Mollie payment method](https://docs.mollie.com/reference/v2/payments-api/create-payment). When checking out an order, the plugin will check if the selected payment method is active in the Mollie account using the API. if the payment method is not active or otherwise invalid, the user will be redirected to the Mollie Checkout page that shows all possible payment methods. - Fixed formatting for the amount > value field using ``` number_format() ``` I believe this is safe because the ``` $this->order->total_in_currency ``` variable is always a float.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.