Merge "Fix "undefined is not an object (evaluating 'navigator.service…

…Worker.controller')""
qtqa · Dec 9, 2024 · e02e6c5 · e02e6c5
2 parents e511344 + 19ffcbb
commit e02e6c5
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/polygerrit-ui/app/services/service-worker-installer.ts b/polygerrit-ui/app/services/service-worker-installer.ts
@@ -77,12 +77,14 @@ export class ServiceWorkerInstaller extends Model<ServiceWorkerInstallerState> {
       ) {
         this.allowBrowserNotificationsPreference =
           prefs.allow_browser_notifications;
-        // flag can disable notifications similar to user setting
-        navigator.serviceWorker.controller?.postMessage({
-          type: ServiceWorkerMessageType.USER_PREFERENCE_CHANGE,
-          allowBrowserNotificationsPreference:
-            this.allowBrowserNotificationsPreference,
-        });
+        if (this.initialized) {
+          // flag can disable notifications similar to user setting
+          navigator.serviceWorker.controller?.postMessage({
+            type: ServiceWorkerMessageType.USER_PREFERENCE_CHANGE,
+            allowBrowserNotificationsPreference:
+              this.allowBrowserNotificationsPreference,
+          });
+        }
       }
     });
     Promise.all([