Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize setup command #217

Closed
0xjei opened this issue Dec 1, 2022 · 0 comments · Fixed by #234
Closed

Modularize setup command #217

0xjei opened this issue Dec 1, 2022 · 0 comments · Fixed by #234
Assignees
@ctrlc03
Labels
Enhancement 🥋 Improve something already existing (e.g., a feature or build process)

Comments

@0xjei
Copy link
Contributor

0xjei commented Dec 1, 2022 •
edited
Loading

The idea is to separate the core logic of the CLI (e.g., authentication with Device Flow) from the parts purely related to the operation of the interface (e.g., theme, console to show a code for the user).

For the setup command, these features will have to be separated and the main test stubs (e2e) must be provided in order to further check against a deployed development environment the core logic underlying the operation of the command.
@0xjei 0xjei mentioned this issue Dec 1, 2022
Merged
@0xjei 0xjei changed the title setup command Modularize setup command Dec 6, 2022
@0xjei 0xjei added the Enhancement 🥋 Improve something already existing (e.g., a feature or build process) label Dec 6, 2022
@0xjei 0xjei removed their assignment Dec 6, 2022
ctrlc03 added a commit to ctrlc03/mpc-phase2-suite that referenced this issue Dec 9, 2022
@ctrlc03
feat(setup): decoupling setup from the cli
9e8b3df 
Moving setup utils from cli to actions

fix quadratic-funding#217
@ctrlc03 ctrlc03 mentioned this issue Dec 9, 2022
Merged
@0xjei 0xjei linked a pull request Dec 14, 2022 that will close this issue
feat(setup): decoupling setup from the cli #234
Merged
@ctrlc03 ctrlc03 closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ctrlc03 ctrlc03

Labels
Enhancement 🥋 Improve something already existing (e.g., a feature or build process)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(setup): decoupling setup from the cli ctrlc03/mpc-phase2-suite
2 participants
@0xjei @ctrlc03