Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fill color should persist while editing #1775

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix: fill color should persist while editing #1775

merged 1 commit into from
Aug 27, 2024

Conversation

AyushAgrawal-A2
Copy link
Collaborator

closes #1740

bug happens after opening CodeEditor side pannel

ref: microsoft/monaco-editor#338 (comment)

Copy link

qa-wolf bot commented Aug 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Aug 23, 2024 4:14am

@cla-bot cla-bot bot added the cla-signed label Aug 23, 2024
@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-1775 August 23, 2024 03:57 Inactive
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.91%. Comparing base (178cfc0) to head (2ba3162).
Report is 50 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #1775   +/-   ##
=======================================
  Coverage   90.91%   90.91%           
=======================================
  Files         206      206           
  Lines       41911    41911           
=======================================
  Hits        38104    38104           
  Misses       3807     3807           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@luke-quadratic luke-quadratic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected!

@davidkircos davidkircos merged commit 49321e4 into qa Aug 27, 2024
14 checks passed
@davidkircos davidkircos deleted the ayush/1740 branch August 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill color should persist while editing
4 participants