Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework code/formula translation & name-updating #2354

Open
wants to merge 6 commits into
base: qa
Choose a base branch
from

Conversation

HactarCE
Copy link
Collaborator

@HactarCE HactarCE commented Feb 28, 2025

  • the first commit is just refactoring a bunch of &SheetId into SheetId so see the second
  • the second commit fixes case-sensitive comparison for column names
  • the third commit is where the substantial changes are

This PR should make table names, column names, and sheet names properly update in formulas when they are renamed.

Copy link

qa-wolf bot commented Feb 28, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2025
@HactarCE HactarCE force-pushed the ajf/refactor-update-code-cell-references branch from 03f1a89 to 89df9fa Compare February 28, 2025 16:41
@HactarCE HactarCE force-pushed the ajf/refactor-update-code-cell-references branch from 89df9fa to 9942fd1 Compare February 28, 2025 16:42
Copy link
Contributor

github-actions bot commented Feb 28, 2025

Preview - Build & Deploy Images

✅ Build images
✅ Deploy images

🕒 Last deployed: Feb 28, 2025 at 09:01 PM UTC

🔗 URL: https://ajf-refactor-update-code-cell-references.quadratic-preview.com

@github-actions github-actions bot temporarily deployed to preview-pr-2354 February 28, 2025 16:46 Destroyed
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 86.75676% with 49 lines in your changes missing coverage. Please review.

Project coverage is 89.92%. Comparing base (184dab4) to head (abb14ee).

Files with missing lines Patch % Lines
quadratic-core/src/formulas/parser/mod.rs 61.36% 34 Missing ⚠️
quadratic-core/src/grid/code_cell.rs 93.07% 9 Missing ⚠️
quadratic-core/src/grid/sheet.rs 37.50% 5 Missing ⚠️
quadratic-core/src/a1/js_selection/create.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               qa    #2354      +/-   ##
==========================================
- Coverage   89.94%   89.92%   -0.03%     
==========================================
  Files         380      380              
  Lines       83720    83798      +78     
==========================================
+ Hits        75306    75353      +47     
- Misses       8414     8445      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to preview-pr-2354 February 28, 2025 16:50 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2354 February 28, 2025 19:01 Destroyed
@github-actions github-actions bot temporarily deployed to preview-pr-2354 February 28, 2025 20:36 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants