Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dbgjs a feature flag #2358

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Make dbgjs a feature flag #2358

merged 2 commits into from
Feb 28, 2025

Conversation

ddimaria
Copy link
Collaborator

@ddimaria ddimaria commented Feb 28, 2025

Creates a default featuredbgjs to core, and turns off this feature for files and multiplayer. I tested locally and no dbgjs! logs appeared in either files or multiplayer.

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2025
Copy link

qa-wolf bot commented Feb 28, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Contributor

github-actions bot commented Feb 28, 2025

Preview - Build & Deploy Images

⏳ Building images...
⏳ Deploy images

🔍 Track progress in the workflow run

@github-actions github-actions bot temporarily deployed to preview-pr-2358 February 28, 2025 19:50 Destroyed
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (184dab4) to head (f8ad01a).
Report is 3 commits behind head on qa.

Additional details and impacted files
@@           Coverage Diff           @@
##               qa    #2358   +/-   ##
=======================================
  Coverage   89.94%   89.95%           
=======================================
  Files         380      380           
  Lines       83720    83720           
=======================================
+ Hits        75306    75307    +1     
+ Misses       8414     8413    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ddimaria ddimaria merged commit 677b778 into qa Feb 28, 2025
22 of 23 checks passed
@ddimaria ddimaria deleted the remove-dbgjs-from-files branch February 28, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants