Update Example Files #280
Merged
Update Example Files #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Closed
jimniels
requested changes
Feb 22, 2023
There was a problem hiding this comment.
Examples look good and are a great iteration over what we previously had 👍
Only thing I noticed: I would suggest we use consistent casing across the files. Right now it's kind of mixed. We should stick to "Sentece case" (first capitalized, all subsequent lower unless proper noun, e.g. "Use Python examples from PIP"
For example, here's the python.grid file
And here's default.grid
Other than that, these look good to me 👍
|
@jimniels I went ahead and made those changes. Ready for review again |
jimniels
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.