Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nAn1 formula notation #346

Merged
merged 11 commits into from
Mar 14, 2023
Merged

Implement nAn1 formula notation #346

merged 11 commits into from
Mar 14, 2023

Conversation

HactarCE
Copy link
Collaborator

@HactarCE HactarCE commented Mar 10, 2023 •
edited by davidkircos
Loading

  • Update Docs
  • Update Visual
  • Update Formaulas Ref
  • Update Examples

CleanShot 2023-03-10 at 15 44 23@2x

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-346.de5w5iglj13on.amplifyapp.com

@davidkircos
Copy link
Collaborator

@davidfig looks pretty good. I think we intended to start at nA instead of bB for negative though.
CleanShot 2023-03-12 at 19 54 23@2x

@davidfig
Copy link
Collaborator

Yup. Fixed:

Screenshot 2023-03-12 at 7 36 03 PM

@davidfig davidfig marked this pull request as ready for review March 13, 2023 02:36
@HactarCE
Copy link
Collaborator Author

I've updated all the text I could find in the docs (Formulas and Overview pages) so I think the images in Overview are all that's left

@davidkircos
Copy link
Collaborator

I've updated all the text I could find in the docs (Formulas and Overview pages) so I think the images in Overview are all that's left

@jimniels can update these

@jimniels
Copy link
Collaborator

Docs have been updated with new imagery https://docs.quadratichq.com/overview

@davidkircos
Copy link
Collaborator

I've updated all the examples and added and fixed the unit tests.

It should be ready for a final review and then merge.

@davidkircos davidkircos self-requested a review March 14, 2023 18:17
jimniels
jimniels approved these changes Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidkircos davidkircos merged commit 23d4914 into main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkircos davidkircos davidkircos approved these changes

@jimniels jimniels jimniels approved these changes

Assignees

@davidfig davidfig

@HactarCE HactarCE

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HactarCE @davidkircos @davidfig @jimniels