Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontally scroll with shift + mouse wheel #367

Closed
wants to merge 5 commits into from

Conversation

davidfig
Copy link
Collaborator

Implements #177

@aws-amplify-us-west-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-367.de5w5iglj13on.amplifyapp.com

@HactarCE
Copy link
Collaborator

Working perfectly on my end!

@davidkircos
Copy link
Collaborator

With a trackpad, this inverses the scroll. Is it possible to have this only effect the mouse scroll, not the trackpad?

@davidfig davidfig requested a review from HactarCE March 25, 2023 18:23
@vercel
Copy link

vercel bot commented May 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2023 6:30pm

Copy link
Collaborator

@jimniels jimniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per David's comment, this appears to affect panning on the trackpad when you hold down shift.

In prod today, if you hold down shift and pan with a trackpad it works the same as if you hold down shift and pan without it.

But with these changes, shift + pan on a trackpad breaks (it sort of pans back and forth just a tiny bit, regardless of the direction you pan)

@jimniels
Copy link
Collaborator

jimniels commented Jun 1, 2023

This is being implemented in #533

@jimniels jimniels closed this Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants