Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add signup button, fix 'back' button on login #686

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

jimniels
Copy link
Collaborator

@jimniels jimniels commented Sep 6, 2023

Sign up

For users viewing a shared file who are not authenticated, we show a message saying they need to login.

If they hit "Log in" they get taken to the auth0 login page:

CleanShot 2023-09-06 at 16 37 52@2x

Where they can login, or if they are new, sign up.

This PR adds an additional "Sign up" button

CleanShot 2023-09-06 at 16 23 13@2x

Which allows them to jump directly to the sign up page:

CleanShot 2023-09-06 at 16 37 37@2x

'Back' button on login

Previous behavior:

  • Load a shared file as a logged out user
  • Click "log in"
  • [app sends user to /login which then redirects them to auth0]
  • Hit the back button
  • End up on auth0 again

When you hit the back button, it's navigating you to /login which automatically redirects you back to auth0. So you get stuck in this loop where hitting "back" doesn't take you back to the file.

New behavior:

  • Load a shared file as a logged out user
  • Click "log in"
  • [app sends user to /login which then redirects them to auth0]
  • Hit the back button
  • End up on the shared file

This properly replaces the /login entry in the history stack so when the user hits "log in" and ends up on auth0, they can hit 'back' in the browser and end up back on the shared file they were just looking at.

Unverified

This user has not yet uploaded their public signing key.
@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
quadratic ✅ Ready (Inspect) Visit Preview Sep 13, 2023 7:50pm

@davidkircos davidkircos temporarily deployed to quadratic-api-dev-pr-686 September 6, 2023 22:56 Inactive
@jimniels jimniels changed the title feat: add signup button feat: add signup button, fix 'back' button on login Sep 6, 2023

Unverified

This user has not yet uploaded their public signing key.
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-686 September 13, 2023 00:31 Inactive
@davidkircos
Copy link
Collaborator

Switch which button is outlined and which one is solid to make "Signup" the more pronounced button:
image

Unverified

This user has not yet uploaded their public signing key.
@jimniels jimniels temporarily deployed to quadratic-api-dev-pr-686 September 13, 2023 19:47 Inactive
@jimniels jimniels merged commit dc8febb into main Sep 13, 2023
@jimniels jimniels deleted the add-signup-button branch September 13, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants