Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ember-cli as peerDependency #101

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Add ember-cli as peerDependency #101

merged 2 commits into from
Sep 9, 2020

Conversation

kenearley
Copy link
Contributor

Adding ember-cli as a peer dependency will add a helpful warning if you have the incompatible versions of ember-cli and ember-cli-dependency-checker.

npm WARN ember-cli-dependency-checker@3.2.0 requires a peer of ember-cli@~3.2.0 but none is installed. You must install peer dependencies yourself.

kenearley added 2 commits June 12, 2019 16:24
@kenearley
Add ember-cli as a peerDependency
649873c 
This should warn users in `npm install` or `yarn install` when they have incompatible versions
@kenearley
remove comma
9a8c120
@quaertym quaertym merged commit 9418f13 into quaertym:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenearley @quaertym