error: declaration of ‘eld::DiagnosticEngine::Severity eld::DiagnosticEngine::State::Severity’ changes meaning of ‘Severity’

[notable-equivalent]

In the definition of the struct DiagnosticEngine::State, we have a member variable Severity which shadows a type called Severity, causing a compilation failure.

eld/include/eld/Diagnostics/DiagnosticEngine.h:183:14: error: declaration of ‘eld::DiagnosticEngine::Severity eld::DiagnosticEngine::State::Severity’ changes meaning of ‘Severity’ [-fpermissive]
  183 |     Severity Severity = Severity::None;
      |              ^~~~~~~~

Issue was seen with GCC-9, which may not be a supported compiler for this project, but as far as I'm aware this is against the language standard in general (see https://stackoverflow.com/a/72130091/14013278) so we shouldn't be doing it.

[quic-seaswara]

Thanks for raising this issue. Let me know if you can raise a patch to fix!

[notable-equivalent]

For now I compiled with -fpermissive to suppress the error. If I have time to recompile LLVM, I can take a look at fixing the issue, but I'm not sure when that might be.

For now, I've identified a list of declarations that I think will cause issues (used a regex search for \b(?<!:)(?!long)([a-zA-Z_][a-zA-Z0-9_]*)\s\1+\b and then manually filtered those that were class members). This should hopefully be the complete list of what needs to be renamed:

include/eld/ScriptParser/ScriptLexer.h
149:  LexState LexState = LexState::Default;
 
include/eld/Diagnostics/DiagnosticEngine.h
183:    Severity Severity = Severity::None;
275:  State State;
 
include/eld/Config/TargetOptions.h
81:  Endian Endian;
 
include/eld/Config/LinkerConfig.h
448:  SearchDirs SearchDirs;
 
test/Hexagon/Plugin/MoveChunksFromOutputSection/MoveChunksFromOutputSection.cpp
16:  Chunk Chunk;

[quic-seaswara]

Sure, take your time to fix.

The builds with clang are not showing any issue, so its perfectly ok to treat this as a good first issue to solve.