Fix fragment padding size computation when output section is unaligned#358
Merged
quic-seaswara merged 1 commit intoqualcomm:mainfrom Oct 3, 2025
Merged
Conversation
Contributor
Author
|
@quic-seaswara @quic-akaryaki I had to mark I tried to create a test case to check for |
quic-seaswara
requested changes
Aug 26, 2025
parth-07
force-pushed
the
FragmentPaddingComputation
branch
from
4a0671a to
b69f537
Compare
quic-seaswara
requested changes
Aug 26, 2025
parth-07
force-pushed
the
FragmentPaddingComputation
branch
2 times, most recently
from
95f9a85 to
54bbee7
Compare
parth-07
force-pushed
the
FragmentPaddingComputation
branch
2 times, most recently
from
3b4eab4 to
fc3e9e0
Compare
parth-07
force-pushed
the
FragmentPaddingComputation
branch
from
fc3e9e0 to
9ec130e
Compare
quic-seaswara
approved these changes
Aug 28, 2025
parth-07
force-pushed
the
FragmentPaddingComputation
branch
2 times, most recently
from
0e891ba to
fe994d7
Compare
parth-07
force-pushed
the
FragmentPaddingComputation
branch
2 times, most recently
from
597b1fd to
7a44424
Compare
parth-07
force-pushed
the
FragmentPaddingComputation
branch
2 times, most recently
from
4d996a0 to
e23c6c3
Compare
This commit fixes fragment padding size computation when output section address is unaligned. The fragment padding size computation (incorrectly) assumed that the fragment offset is congruent to the output section address (modulo fragment alignment). This assumption is violated when the output section address is explicitly specified in the linker script. This change is causing UnalignedCrash.test to fail because the test expects the link to fail but now the link is passing. The link passing seems correct as both bfd/lld pass as well for this test case. Resolves qualcomm#346 Change-Id: I983658470b03583774593c4889a26dd6c7fff800 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
parth-07
force-pushed
the
FragmentPaddingComputation
branch
from
e23c6c3 to
f33174d
Compare
quic-seaswara
approved these changes
Oct 3, 2025
quic-seaswara
approved these changes
Oct 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes fragment padding size computation when output section address is unaligned. The fragment padding size computation (incorrectly) assumed that the fragment offset is congruent to the output section address (modulo fragment alignment). This assumption is violated when the output section address is explicitly specified in the linker script.
This change is causing UnalignedCrash.test to fail because the test expects the link to fail but now the link is passing. The link passing seems correct as both bfd/lld pass as well for this test case.
Resolves #346