Fix windows nightly failures#729
Merged
quic-seaswara merged 1 commit intoqualcomm:mainfrom Jan 23, 2026
Merged
Conversation
This patch fixes windows nightly failures related to `/dev/null` path issue and multiconfig build related path issue. Signed-off-by: Rishabh Bali <rbali@qti.qualcomm.com>
quic-seaswara
approved these changes
Jan 23, 2026
| @@ -1,3 +1,4 @@ | |||
| #UNSUPPORTED: windows | |||
Contributor
There was a problem hiding this comment.
Why is it not working on windows? Is there a plan to fix the root cause and reenable it?
| ; RUN: %link %linkopts --plugin-opt=debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s | ||
| ; RUN: %link %linkopts --lto-debug-pass-manager -o /dev/null %t.o 2>&1 | FileCheck %s | ||
| ; RUN: %link %linkopts --plugin-opt=debug-pass-manager -o %t.temp %t.o 2>&1 | FileCheck %s | ||
| ; RUN: %link %linkopts --lto-debug-pass-manager -o %t.temp %t.o 2>&1 | FileCheck %s |
Contributor
There was a problem hiding this comment.
Do we have other tests that use /dev/null as output path?
Contributor
|
Yes, I have asked to handle both of these as follow ups. /dev/null needs to be probably regarded specially on windows as well. Rishabh, please open follow up tickets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes windows nightly failures related to
/dev/nullpath issue and multiconfig build related path issue.