Fix resolving script inputs path when sysroot is specified#791
Merged
quic-seaswara merged 1 commit intoqualcomm:mainfrom Feb 9, 2026
Merged
Fix resolving script inputs path when sysroot is specified#791quic-seaswara merged 1 commit intoqualcomm:mainfrom
quic-seaswara merged 1 commit intoqualcomm:mainfrom
Conversation
parth-07
force-pushed
the
SysrootScriptInputs
branch
from
8ea55c6 to
359f035
Compare
This commit fix the behavior of searching script inputs such that if the script input is found in the specified absolute / relative path, then the sysroot is not used to find the script. This change is done to make to eld behavior consistent with the other major linkers (such as bfd). Resolves qualcomm#786 Signed-off-by: Parth Arora <partaror@qti.qualcomm.com>
parth-07
force-pushed
the
SysrootScriptInputs
branch
from
359f035 to
d31a5ce
Compare
partaror
changed the title
quic-seaswara
approved these changes
Feb 9, 2026
Contributor
|
Thanks for fixing this @parth-07! Just a heads up, I think we're seeing Windows failures with this over in cpullvm--it's a WIP branch, but see ex: https://github.com/qualcomm/cpullvm-toolchain/actions/runs/21848478483/job/63049668083?pr=150 Looks like the eld Windows nightly is in progress, so I'll keep an eye on that too and see if the failure shows up there. Edit: does seem eld's nightly is failing in the same way: https://github.com/qualcomm/eld/actions/runs/21849978400/job/63054152522 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fix the behavior of searching script inputs such that
if the script input is found in the specified absolute / relative path,
then the sysroot is not used to find the script. This change is done to
make to eld behavior consistent with the other major linkers (such as bfd).
Resolves #786