Read merge string sections in parallel#814
Open
quic-areg wants to merge 1 commit intoqualcomm:mainfrom
Open
Conversation
Contributor
Author
|
some stats linking clang (debug) with eld (release): before: |
quic-areg
force-pushed
the
parallel-strings
branch
from
83d45d4 to
a5a75e0
Compare
| return std::make_unique<plugin::DiagnosticEntry>( | ||
| plugin::DiagnosticEntry(Diag::err_cannot_read_section, | ||
| {S->name().str()})); | ||
| } |
Contributor
There was a problem hiding this comment.
compressed section no longer supported ?
Contributor
Author
There was a problem hiding this comment.
Thank you for catching this! I am surprised how test/Common/standalone/CompressedSections/ReadCompressedSections.test was able to pass without this though
quic-areg
force-pushed
the
parallel-strings
branch
2 times, most recently
from
f4c8afc to
6242961
Compare
Read merge string sections after section discovery and use llvm::parallelFor to parse the strings concurrently when threads are enabled. This reduces time spent in merge string parsing on inputs with many SHF_MERGE|SHF_STRINGS sections. Signed-off-by: quic-areg <aregmi@qti.qualcomm.com>
quic-areg
force-pushed
the
parallel-strings
branch
from
6242961 to
f026c8f
Compare
quic-seaswara
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read merge string sections after section discovery and use
llvm::parallelFor to parse the strings concurrently when threads
are enabled. This reduces time spent in merge string parsing on
inputs with many SHF_MERGE|SHF_STRINGS sections.