Skip to content

Conversation

@yuval-qf
Copy link
Collaborator

Description

Motivation and Context

Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“ Documentation update
  • 🎨 Code style/refactoring (no functional changes)
  • πŸ§ͺ Test updates
  • πŸ”§ Configuration/build changes

Changes Made

Screenshots/Examples (if applicable)

Checklist

  • I have read the CONTRIBUTING.md guide
  • My code follows the code style of this project (PEP 8, type hints, docstrings)
  • I have run uv run black . to format my code
  • I have run uv run flake8 . and fixed all issues
  • I have run uv run mypy --config-file .mypy.ini . and addressed type checking issues
  • I have run uv run bandit -c .bandit.yaml -r . for security checks
  • I have added tests that prove my fix is effective or that my feature works
  • I have run uv run pytest and all tests pass
  • I have manually tested my changes
  • I have updated the documentation accordingly
  • I have added/updated type hints for new/modified functions
  • My changes generate no new warnings
  • I have checked my code for security issues
  • Any dependent changes have been merged and published

Testing

Test Configuration:

  • Python version:
  • OS:
  • Other relevant details:

Test Steps:
1.
2.
3.

Additional Notes

Related Issues/PRs

  • Fixes #
  • Related to #
  • Depends on #

@yuval-qf yuval-qf self-assigned this Oct 23, 2025
@yuval-qf yuval-qf requested a review from drorIvry as a code owner October 23, 2025 10:17
@yuval-qf yuval-qf had a problem deploying to rogue-sanity-ci-secrets October 23, 2025 10:17 — with GitHub Actions Failure
@yuval-qf yuval-qf merged commit a28f25a into main Oct 23, 2025
8 of 9 checks passed
@yuval-qf yuval-qf deleted the fix/rogue-sanity-ci branch October 23, 2025 13:47
ignorant05 pushed a commit to ignorant05/rogue that referenced this pull request Oct 24, 2025
@drorIvry drorIvry mentioned this pull request Nov 10, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants