Skip to content

Hotfix | suppress known warnings#128

Merged
drorIvry merged 1 commit intomainfrom
hotfix/ignore-websocket-warnings
Nov 5, 2025
Merged

Hotfix | suppress known warnings#128
drorIvry merged 1 commit intomainfrom
hotfix/ignore-websocket-warnings

Conversation

@yuval-qf
Copy link
Collaborator

@yuval-qf yuval-qf commented Nov 4, 2025

Description

Motivation and Context

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📝 Documentation update
  • 🎨 Code style/refactoring (no functional changes)
  • 🧪 Test updates
  • 🔧 Configuration/build changes

Changes Made

Screenshots/Examples (if applicable)

Checklist

  • I have read the CONTRIBUTING.md guide
  • My code follows the code style of this project (PEP 8, type hints, docstrings)
  • I have run uv run black . to format my code
  • I have run uv run flake8 . and fixed all issues
  • I have run uv run mypy --config-file .mypy.ini . and addressed type checking issues
  • I have run uv run bandit -c .bandit.yaml -r . for security checks
  • I have added tests that prove my fix is effective or that my feature works
  • I have run uv run pytest and all tests pass
  • I have manually tested my changes
  • I have updated the documentation accordingly
  • I have added/updated type hints for new/modified functions
  • My changes generate no new warnings
  • I have checked my code for security issues
  • Any dependent changes have been merged and published

Testing

Test Configuration:

  • Python version:
  • OS:
  • Other relevant details:

Test Steps:
1.
2.
3.

Additional Notes

Related Issues/PRs

  • Fixes #
  • Related to #
  • Depends on #

@yuval-qf yuval-qf requested a review from drorIvry as a code owner November 4, 2025 12:13
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 4, 2025

Summary by CodeRabbit

Release Notes

  • Chores
    • Configured example application for development and testing
    • Suppressed internal deprecation warnings for cleaner console output during runtime

Walkthrough

Reorganizes deprecation warning suppressions from the main entrypoint across package-level initialization files, moving suppression calls from rogue/__main__.py to rogue/__init__.py and rogue/server/__init__.py. Updates the VS Code launch configuration to execute with the tshirt_store example flag and adds warning suppression to the example package itself.

Changes

Cohort / File(s) Summary
Debug & Launch Configuration
\.vscode/launch.json
Added --example=tshirt_store to Rogue AIO launch args for running the example during debugging
Deprecation Warning Suppression Reorganization
rogue/__main__.py
Removed local DeprecationWarning suppression for websockets (moved upstream to module initializers)
Deprecation Warning Suppression Reorganization
rogue/__init__.py, rogue/server/__init__.py
Added DeprecationWarning suppression filters for websockets-related deprecations at package initialization time
Example Package Initialization
examples/tshirt_store_agent/__init__.py
Added DeprecationWarning suppression filter to silence warnings during example execution

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Homogeneous pattern: warning filter additions follow a consistent template across multiple files
  • Primary consideration: Verify that moving warning suppression from __main__.py to lower-level __init__.py files achieves the intended effect of suppressing warnings at import time
  • Configuration change is straightforward (--example=tshirt_store launch arg)

Possibly related PRs

  • feature/aio example script #51: Introduced example agent flow support; this PR's launch configuration changes and example package initialization directly build upon that example-agent infrastructure.

Suggested reviewers

  • drorIvry
  • osher-qualifire

Poem

🐰 Warning filters hop from main to init,
Tucked in packages, a tidy bit!
T-shirt store example now launches with flair,
Less noise, more code—cleaner everywhere! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is entirely blank/templated with no content filled in. All sections including Description, Motivation, Type of Change, and Changes Made are empty with no actual information provided. Complete the PR description with actual details: explain the motivation for suppressing warnings, specify which warnings are suppressed and why, check the appropriate Type of Change box, list the files modified, and provide testing information.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Hotfix | suppress known warnings' accurately reflects the main change—suppressing deprecation warnings across multiple files in the rogue module.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hotfix/ignore-websocket-warnings

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8b6c517 and e55b8f4.

📒 Files selected for processing (5)
  • .vscode/launch.json (1 hunks)
  • examples/tshirt_store_agent/__init__.py (1 hunks)
  • rogue/__init__.py (1 hunks)
  • rogue/__main__.py (0 hunks)
  • rogue/server/__init__.py (1 hunks)
💤 Files with no reviewable changes (1)
  • rogue/main.py
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

**/*.py: Format Python code with Black
Ensure code passes flake8 linting
Run mypy with the repository configuration for static typing
Run Bandit security checks using .bandit.yaml configuration
Use isort import conventions for import ordering
Add type hints to all function signatures
Follow PEP 8 naming (snake_case for variables/functions, PascalCase for classes)
Use try/except around code that may raise exceptions

Files:

  • rogue/server/__init__.py
  • examples/tshirt_store_agent/__init__.py
  • rogue/__init__.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: rogue_sanity
  • GitHub Check: codestyle
🔇 Additional comments (1)
.vscode/launch.json (1)

80-82: LGTM!

The addition of the --example=tshirt_store flag to the Rogue AIO launch configuration is appropriate for development and testing purposes.

@yuval-qf yuval-qf changed the title Hotfix | supress known warnings Hotfix | suppress known warnings Nov 5, 2025
@drorIvry drorIvry merged commit 6503739 into main Nov 5, 2025
9 checks passed
@drorIvry drorIvry deleted the hotfix/ignore-websocket-warnings branch November 5, 2025 10:23
@drorIvry drorIvry mentioned this pull request Nov 10, 2025
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants