Bugfix | Github Workflow | Support release from ui

[yuval-qf]

Description

Motivation and Context

Type of Change

• 🐛 Bug fix (non-breaking change which fixes an issue)
• ✨ New feature (non-breaking change which adds functionality)
• 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
• 📝 Documentation update
• 🎨 Code style/refactoring (no functional changes)
• 🧪 Test updates
• 🔧 Configuration/build changes

Changes Made

Screenshots/Examples (if applicable)

Checklist

• I have read the CONTRIBUTING.md guide
• My code follows the code style of this project (PEP 8, type hints, docstrings)
• I have run uv run black . to format my code
• I have run uv run flake8 . and fixed all issues
• I have run uv run mypy --config-file .mypy.ini . and addressed type checking issues
• I have run uv run bandit -c .bandit.yaml -r . for security checks
• I have added tests that prove my fix is effective or that my feature works
• I have run uv run pytest and all tests pass
• I have manually tested my changes
• I have updated the documentation accordingly
• I have added/updated type hints for new/modified functions
• My changes generate no new warnings
• I have checked my code for security issues
• Any dependent changes have been merged and published

Testing

Test Configuration:

• Python version:
• OS:
• Other relevant details:

Test Steps:
1.
2.
3.

Additional Notes

Related Issues/PRs

• Fixes #
• Related to #
• Depends on #

---

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The release workflow is enhanced with a release-existence check that conditionally creates a new release or attaches artifacts to an existing one based on whether a release for the current tag already exists.

Changes

Cohort / File(s)	Summary
GitHub Actions Release Workflow .github/workflows/release.yml	Adds release-existence validation step and introduces conditional branching: skip release creation if one already exists for the tag; attach artifacts to existing release instead. Conditional logic determines whether to create or update.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• drorIvry

Poem

🐰 A release workflow, refined and aware,
Checks if versions already there,
Create new or attach with care,
No duplicates—pristine and fair! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The PR description is entirely empty with only template placeholders, providing no information about the changes, motivation, or any checklist items.	Fill in the description template with: the change summary, motivation/issue link, type of change, specific changes made, and completed checklist items relevant to workflow changes.
Title check	❓ Inconclusive	The title references GitHub workflow release functionality, which aligns with the changeset's modifications to the release.yml workflow, but uses unclear phrasing ('from ui') that doesn't clearly convey the actual change.	Clarify the title to better reflect the core change: supporting attaching files to existing releases instead of always creating new ones, e.g., 'Support attaching artifacts to existing GitHub releases'.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

.github/workflows/release.yml (2)

164-173: Quote the tag name variable for shell safety.

While tag names typically don't contain special characters, quoting ${{ github.ref_name }} is a defensive shell scripting practice that prevents potential issues with unexpected characters.

Suggested fix

       - name: Check if release exists
         id: check_release
         run: |
-          if gh release view ${{ github.ref_name }} >/dev/null 2>&1; then
+          if gh release view "${{ github.ref_name }}" >/dev/null 2>&1; then
             echo "exists=true" >> $GITHUB_OUTPUT
           else
             echo "exists=false" >> $GITHUB_OUTPUT
           fi
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

---

191-201: Explicitly set overwrite_files for clarity.

The attach step correctly runs when the release exists. Note that softprops/action-gh-release@v2 defaults to overwrite_files: true, meaning re-runs for the same tag will overwrite existing assets. Consider adding overwrite_files: true explicitly in the with block to document this behavior clearly, or set it to false if you want to preserve existing assets.

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53e4434 and 9409627.

📒 Files selected for processing (1)

• .github/workflows/release.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: codestyle

🔇 Additional comments (1)

.github/workflows/release.yml (1)

175-189: LGTM!

The conditional logic correctly gates release creation on the non-existence check.