Merge pull request voyagegroup#11 from moneyforwardvietnam/revert-8-f…

…ix-module Revert "fix error null resource"
quangnhut123 · May 16, 2024 · 07a45fc · 07a45fc
2 parents a76485a + 89dc4e4
commit 07a45fc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/cluster/iam.tf b/cluster/iam.tf
@@ -44,7 +44,7 @@ data "aws_iam_policy_document" "s3_policy_document" {
     actions = [
       "s3:*",
     ]
-    resources = var.s3_policy && length(var.bucket_arn_list) > 0 ? [ for arn in var.bucket_arn_list : "${arn}/*" ] : ""
+    resources = var.s3_policy && length(var.bucket_arn_list) > 0 ? [ for arn in var.bucket_arn_list : "${arn}/*" ] : null
 
   }
 }

diff --git a/service_load_balancing/launch_type_fargate.tf b/service_load_balancing/launch_type_fargate.tf
@@ -133,14 +133,14 @@ resource "aws_iam_role_policy" "fargate_s3" {
         "s3:ListBucket",
         "s3:GetBucketLocation"
       ],
-      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? ${var.bucket_arn_list} : ""
+      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? ${var.bucket_arn_list} : null
     },
     {
       "Effect": "Allow",
       "Action": [
         "s3:*"
       ],
-      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? [ for arn in ${var.bucket_arn_list} : "${arn}/*" ] : ""
+      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? [ for arn in ${var.bucket_arn_list} : "${arn}/*" ] : null
     }
   ]
 }

diff --git a/service_load_balancing/launch_type_fargate_no_alb.tf b/service_load_balancing/launch_type_fargate_no_alb.tf
@@ -109,14 +109,14 @@ resource "aws_iam_role_policy" "fargate_no_alb_s3" {
         "s3:ListBucket",
         "s3:GetBucketLocation"
       ],
-      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? ${var.bucket_arn_list} : ""
+      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? ${var.bucket_arn_list} : null
     },
     {
       "Effect": "Allow",
       "Action": [
         "s3:*"
       ],
-      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? [ for arn in ${var.bucket_arn_list} : "${arn}/*" ] : ""
+      "Resource": ${var.s3_policy} && length(${var.bucket_arn_list}) > 0 ? [ for arn in ${var.bucket_arn_list} : "${arn}/*" ] : null
     }
   ]
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,7 +44,7 @@ data "aws_iam_policy_document" "s3_policy_document" { @@
         actions = [
           "s3:*",
         ]
-        resources = var.s3_policy && length(var.bucket_arn_list) > 0 ? [ for arn in var.bucket_arn_list : "${arn}/*" ] : ""
+        resources = var.s3_policy && length(var.bucket_arn_list) > 0 ? [ for arn in var.bucket_arn_list : "${arn}/*" ] : null
       }
     }
@@ Expand Down @@