Merge pull request #2278 from quantified-uncertainty/user-event-fix

@testing-library/user-event types are fixed, remove our workaround
quantified-uncertainty · Sep 15, 2023 · 9cc2941 · 9cc2941 · vercel · Sep 15, 2023
2 parents a6a68d2 + 5c1c7a0
commit 9cc2941
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 21 deletions.
diff --git a/packages/components/package.json b/packages/components/package.json
@@ -57,7 +57,7 @@
     "@storybook/react-vite": "^7.2.1",
     "@testing-library/jest-dom": "^5.16.5",
     "@testing-library/react": "^14.0.0",
-    "@testing-library/user-event": "^14.4.3",
+    "@testing-library/user-event": "^14.5.1",
     "@types/jest": "^29.5.3",
     "@types/lodash": "^4.14.196",
     "@types/node": "^20.4.7",

diff --git a/packages/components/test/autorun.test.tsx b/packages/components/test/autorun.test.tsx
@@ -1,6 +1,6 @@
 import "@testing-library/jest-dom";
 import { act, render, screen, waitFor } from "@testing-library/react";
-import { userEvent } from "./user-event.js";
+import { userEvent } from "@testing-library/user-event";
 
 import { SquigglePlayground } from "../src/index.js";
 
@@ -14,7 +14,7 @@ test("Autorun is default", async () => {
 });
 
 test("Autorun can be switched off", async () => {
-  const user = userEvent.setup(); // typescript issue is due to ESM mess
+  const user = userEvent.setup();
   act(() => render(<SquigglePlayground defaultCode="70*30" />));
 
   expect(screen.getByTestId("autorun-controls")).toHaveAttribute(
@@ -28,10 +28,9 @@ test("Autorun can be switched off", async () => {
     )
   );
 
-  await act(
-    async () =>
-      await user.click(screen.getByTestId("autorun-controls").firstChild) // disable
-  );
+  await act(async () => {
+    await user.click(screen.getByTestId("autorun-controls").firstElementChild!); // disable
+  });
 
   expect(screen.getByTestId("autorun-controls")).toHaveAttribute(
     "aria-checked",

diff --git a/packages/components/test/user-event.ts b/packages/components/test/user-event.ts
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml