Hub DB; turbo generator #3686
Merged
Hub DB; turbo generator #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
4 Skipped Deployments
|
OAGr
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the DB layer from
apps/hubin the same fashion as I did recently for metaforecast.This will allow us to write internal packages that use hub's db without keeping all code in
apps/hubunder next.js control (which creates problems, e.g. for squiggle build script).I'm not 100% sure this will be necessary for evals or not, but using the same pattern for both apps will reduce the burden of maintenance, and I remember having some trouble with esbuild setup in
apps/hubpreviously, so this seems safer.One minor downside of this approach is that you'll need to keep
DATABASE_URL=...in.envboth forapps/huband forinternal-packages/hub-db. But I think it's not that big of a deal.This PR also introduces a top-level
turbo/generatorspackage, which allows you to doturbo gen internal-package -a NAME(see https://turbo.build/repo/docs/guides/generating-code#custom-generators).I expect that we'll make significantly more internal packages in the future, so it's good to encode our current practices and patterns for new packages in code.