Allow default path for containers to be set in frontmatter #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be better to implement the same docker logic that remembers where the containers last working dir was? |
|
@patricoferris yeah, I think that'd be good - I just wasn't sure how easy it'd be to bounce that around with the saved containers |
|
Cool I might look into it ocurrent/obuilder#182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a quick way to save my sanity with the TMF. We have a hardcoded default path in containers of "/root" this change lets you override that in front matter.
Currently it's overridden for all containers with the same value, and I suspect we need it to be per container name. But for now this is a minimal change to stop me starting every block in the TMF runorder.md with a change directory command.