Fix: Support empty style attribute #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug in which empty style attributes result in
unrecoverable JSX failures. For example:
```html
<div style>Foo</div>
```
Would result in the following console error:
```
Uncaught Invariant Violation: The `style` prop expects a
mapping from style properties to values, not a string.
For example, style={{marginRight: spacing + 'em'}} when
using JSX.
```
and the React JSX failing to render.
The problem is that empty properties are rendered as
boolean `true` by default. This is consistent with
HTML/React syntax interop expectations for most properties
but not `style`, which expects an `Object` value in
React-land.
Since an empty `style` attribute is semantically
meaningless (where HTML is concerned) we can simply skip
over this property.
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 99.22% 99.22%
=======================================
Files 1 1
Lines 386 387 +1
Branches 64 65 +1
=======================================
+ Hits 383 384 +1
Misses 3 3
Continue to review full report at Codecov.
|
cribbles
pushed a commit
to contentful/field-editors
that referenced
this pull request
Apr 2, 2020
Pulls in a pre-compiled local branch including the changes from this `markdown-to-jsx` PR: quantizor/markdown-to-jsx#296 which in turn fixes a bug in which empty style attributes (e.g. `<div style>Foo</div>`) would cause unrecoverable crashes in the markdown field editor.
cribbles
pushed a commit
to contentful/field-editors
that referenced
this pull request
Apr 3, 2020
Pulls in a pre-compiled local branch including the changes from this `markdown-to-jsx` PR: quantizor/markdown-to-jsx#296 which in turn fixes a bug in which empty style attributes (e.g. `<div style>Foo</div>`) would cause unrecoverable crashes in the markdown field editor.
|
Thanks |
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in which empty style attributes result in unrecoverable JSX failures. For example:
Would result in the following console error:
and the React JSX failing to render.
The problem is that empty properties are rendered as boolean
trueby default. This is consistent with HTML/React syntax interop expectations for most properties but notstyle, which expects anObjectvalue in React-land.Since an empty
styleattribute is semantically meaningless (where HTML is concerned) we can simply skip over this property.