Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for Syntax highlighting #384

Merged

Conversation

stephan-noel
Copy link
Contributor

Closes #367

I had to dig a bit to find out that markdown-to-jsx does this. It also passes lang- (ie lang-json) as an attribute to the DOM node for <code> but I left that out for the sake of brevity.

@stephan-noel
Copy link
Contributor Author

Some element mappings are different frommdx-js , being that markdown-to-jsx doesn't have its own table, it's natural to assume that people would assume the table from mdx-js works. It's useful to point out the differences.

It's probably preferable for mdx-js to have its own table mapping of components. If you agree I can add one.

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@quantizor quantizor merged commit 0792df9 into quantizor:main May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax Highlighting
2 participants