Allow list items etc. to terminate paragraphs #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikonst
commented
Dec 11, 2021
index.tsx
Outdated
| break | ||
| } | ||
| match += line + '\n' | ||
| if (/^\s*$/.test(line)) { |
There was a problem hiding this comment.
Would this be equivalent?
Suggested change
| if (/^\s*$/.test(line)) { | |
| if (!line.trim()) { |
There was a problem hiding this comment.
Trim appears to be significantly faster, so let's go with that
ikonst
commented
Dec 11, 2021
|
@probablyup bump! |
|
Just wanted to quickly say I haven't forgotten about this! I've had COVID since the new year and am finally starting to feel normal again. Should have some time for OSS work this weekend. |
quantizor
requested changes
Jan 15, 2022
index.tsx
Outdated
| break | ||
| } | ||
| match += line + '\n' | ||
| if (/^\s*$/.test(line)) { |
There was a problem hiding this comment.
Trim appears to be significantly faster, so let's go with that
quantizor
reviewed
Jan 16, 2022
quantizor
approved these changes
Jan 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another stab at #256. Unlike #291, I'm matching the paragraph imperatively rather than with a regex.
Fixes #256.