Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): allow replacing of special capital html characters #448

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

garywilddev
Copy link
Contributor

Allows HTML character codes starting with a capital letter to be replaced.

#447

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Should we add numbers too to support the full range?

@aitorllj93
Copy link

Hi @probablyup @garywilddev what's the current state of this? can at least the uppercase characters be merged so we can fix those cases? Is there any additional complexity involved on the numeric ones?

@garywilddev
Copy link
Contributor Author

Hi @d3v0ps and @probablyup ,
Sorry I was on long holidays.
I took a look at the code to add support for html numeric codes, but I struggle a bit when using the same approach as for html character codes.
Could we consider merging this PR, as the behaviour for html character codes is satisfactory and I'll open later another Issue and a PR for numeric codes ?

@quantizor
Copy link
Owner

Need to at least get tests passing

@garywilddev
Copy link
Contributor Author

Hi @probablyup,
I merged main into my branch.
Tests are now successful again.

Copy link
Owner

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@quantizor quantizor merged commit ebd044a into quantizor:main Jan 31, 2023
Innei pushed a commit to Innei/markdown-to-jsx that referenced this pull request Aug 2, 2023
Innei pushed a commit to Innei/markdown-to-jsx that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants