-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP8 and unify codebase #1
Comments
@gusgordon This seems mostly done, no? |
Pretty much. There are some variable names that are still a bit questionable, though, like x_TS. I'll give those better names today then this can be closed. |
@justinlent Does it make sense to rename "algo_ts" to "df_cum_rets"? I think algo_ts is just the cumulative version of df_rets, no? I think once those bt names get cleaned up and the above is sorted out this issue can be closed. |
@gusgordon Yeah, I like that recommendation ^^ to rename algo_ts to the more informative 'df_cum_rets' Also, I just responded in the HC room about some ideas for renaming the bt_* variables |
+1 |
DOC: fix docstring for rolling volatility
Use e.g.
autopep8
to make the syntax correspond to pep8.Also, the functions use different naming conventions, change all to use
underscore_style
rather thancamelCase
.The text was updated successfully, but these errors were encountered: