-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yahoo URL Error #385
Comments
That seems like a bug in pandas-datareader. |
Hi @merl-dev we're also seeing this over in quantopian/zipline#1776. It looks like Yahoo has made some changes to their API and is expecting some sort of cookie/session tracking |
Yes it would appear so, the download link on a history request at yahoo finance has changed url, query params, and now includes a session token. Do they ever document these changes? |
I've created a workaround that substitutes out yahoo for google data. I'm sure there are some ticker mis-matches that could cause issues, but for my purposes tonight it solves it. Pull request coming shortly %matplotlib inline
import pyfolio as pf
import pandas as pd
import numpy as np
stock_rets = pf.utils.get_symbol_rets('AGG')
print stock_rets.tail() returns Date
2017-05-11 00:00:00+00:00 -0.000092
2017-05-12 00:00:00+00:00 0.003686
2017-05-15 00:00:00+00:00 -0.000367
2017-05-16 00:00:00+00:00 0.001286
2017-05-17 00:00:00+00:00 0.005137
Name: AGG, dtype: float64 |
There's an unmerged fix in After that's implemented, we can bump the required version of datareader. We could also additionally put in the Google fallback in #386. @twiecki thoughts? |
Yes agreed. And I like the idea of a fallback.
…On May 24, 2017 4:20 PM, "Gus Gordon" ***@***.***> wrote:
There's an unmerged fix in pandas-datareader: pydata/pandas-datareader#331
<pydata/pandas-datareader#331> I suppose we
should wait until they push this and do a release.
After that's implemented, we can bump the required version of datareader.
We could also additionally put in the Google fallback in #386
<#386>.
@twiecki <https://github.com/twiecki> thoughts?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#385 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApJmN5KYbg6U_9wI0NTox2G6TwB7Espks5r9DypgaJpZM4NdwbP>
.
|
My super quick hack to get at least something going:
As in #380 be nice to have options to disable those benchmarks to prevent those kinds of issues (while the underlying problem gets fixed). |
Just ran into this as I am trying to get started,, As it seems Yahoo is out of the business or at the least unstable, and Pandas_datareader can handle Google and other datasources.. at the moment.. Seems like it would be great to have a variable or separate io module that can be swapped out, to be set as to what data source to use for all of the pyfolio data sources, with yahoo and data reader so baked it, there seems no easy fix...? TIA If anyone has suggestions I'm interested! |
I've just run into the same issue. It would be great to remove the dependence on external data and just make it an option. |
Same, issue, agree with chrism, maybe users can provide both returns (stocks/portfolio) and benchmark as citynorm mentioned! |
When the following is run
I get a RemoteDataError for the baked-in URL. Apparently Yahoo has made some recent changes to their API's
The text was updated successfully, but these errors were encountered: