-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New release for pyfolio #414
Comments
Yes, should absolutely cut a new release! Want to do a PR that updates the version number and has a release announcement with a list of new features (similar to what you have here)? |
I'll draft a release and organize a milestone so we know what PRs to wait for and what not to. A milestone will be better than an issue :) |
I just remembered @twiecki I had drafted a new release announcement on github, but since my access has been revoked I assume its lost. You can just use my comment above to draft a new one. |
Nothing should get lost. It's either on a branch you pushed or on a local branch of yours. Where did you keep it? |
As a draft release: click "10 releases" on the info bar on the pyfolio github home page. |
@twiecki @gusgordon once @vikram-narayan's perf attributions are done we can cut a new version of pyfolio, everything else is merged. |
We can probably already do that now given the changes and refactorings we have. |
If you think that would be a good idea! 🎉 |
@eigenfoo Want to do a PR with the release announcements and version bump to |
Will do! |
Hi, isn't the changes of requirements breaking the requirements of zipline 1.1.1 zipline 1.1.1 : pandas==0.18.1 zipline 1.1.1: empyrical==0.2.2 Source: you may say: you don't need ZL with pyfolio. Am I doing something wrong? |
@bonesmccoy Hm, that's indeed a pickle (no pun intended). The empyrical version mismatch should be fixed easily, the pandas one might be more tricky. CC @richafrank |
We can probalby make pyfolio pandas 0.18.1 compat without too much effort (if it isn't already). |
Yup, we'll be fixing the pandas issue soon, unless you get to it first. zipline doesn't read the reqs.txt literally and actually supports empyrical>=2.2, so I don't think that's an issue here, unless you specifically want to use empyrical<0.3.2. |
Closed by #552 |
It looks like enough has changed on pyfolio to merit v0.8.0 (with risk and performance attribution, I think we might even want to call it v1.0.0!)
We are also seeing an increasing number of users running into bugs that have already been patched: upping the version would make it easier to diagnose errors (both ours, and open source users).
To-do:
@twiecki @gusgordon @richafrank @Jstauth thoughts? If this sounds good I'll organize a milestone :)
New features
Bugfixes
information_ratio
to remain compatible with empyricalMaintenance
The text was updated successfully, but these errors were encountered: