Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release for pyfolio #414

Closed
1 of 4 tasks
eigenfoo opened this issue Aug 14, 2017 · 15 comments
Closed
1 of 4 tasks

New release for pyfolio #414

eigenfoo opened this issue Aug 14, 2017 · 15 comments
Milestone

Comments

@eigenfoo
Copy link
Contributor

eigenfoo commented Aug 14, 2017

It looks like enough has changed on pyfolio to merit v0.8.0 (with risk and performance attribution, I think we might even want to call it v1.0.0!)

We are also seeing an increasing number of users running into bugs that have already been patched: upping the version would make it easier to diagnose errors (both ours, and open source users).

To-do:

@twiecki @gusgordon @richafrank @Jstauth thoughts? If this sounds good I'll organize a milestone :)

New features

  • Risk tear sheet: added a new tear sheet to analyze risk exposures to common factors, sector, market cap and illiquidity (Risk tear sheet #391)
  • Simple tear sheet: added a new tear sheet that presents only the most important plots in the full tear sheet, for a quick general overview of a portfolio's performance (Simple Tearsheet #389)
  • Volatility plot: added a rolling annual volatility plot in the returns tear sheet (fixes #278 #390)

Bugfixes

Maintenance

@twiecki
Copy link
Contributor

twiecki commented Aug 14, 2017

Yes, should absolutely cut a new release! Want to do a PR that updates the version number and has a release announcement with a list of new features (similar to what you have here)?

@eigenfoo
Copy link
Contributor Author

I'll draft a release and organize a milestone so we know what PRs to wait for and what not to. A milestone will be better than an issue :)

@eigenfoo eigenfoo added this to the v1.0.0 milestone Aug 15, 2017
@eigenfoo
Copy link
Contributor Author

I just remembered @twiecki I had drafted a new release announcement on github, but since my access has been revoked I assume its lost. You can just use my comment above to draft a new one.

@eigenfoo eigenfoo reopened this Aug 21, 2017
@twiecki
Copy link
Contributor

twiecki commented Aug 21, 2017

Nothing should get lost. It's either on a branch you pushed or on a local branch of yours. Where did you keep it?

@eigenfoo
Copy link
Contributor Author

As a draft release: click "10 releases" on the info bar on the pyfolio github home page.

@eigenfoo
Copy link
Contributor Author

eigenfoo commented Aug 23, 2017

@twiecki @gusgordon once @vikram-narayan's perf attributions are done we can cut a new version of pyfolio, everything else is merged.

@twiecki
Copy link
Contributor

twiecki commented Aug 23, 2017

We can probably already do that now given the changes and refactorings we have.

@eigenfoo
Copy link
Contributor Author

If you think that would be a good idea! 🎉

@twiecki
Copy link
Contributor

twiecki commented Aug 23, 2017

@eigenfoo Want to do a PR with the release announcements and version bump to 0.8.0?

@eigenfoo
Copy link
Contributor Author

Will do!

@bonesmccoy
Copy link

Hi, isn't the changes of requirements breaking the requirements of zipline 1.1.1

zipline 1.1.1 : pandas==0.18.1
pyfolio 0.8.0: pandas>=0.19.0

zipline 1.1.1: empyrical==0.2.2
pyfolio 0.8.0: empyrical>=0.3.2

Source:
Pyfolio: https://github.com/quantopian/pyfolio/blob/v0.8.0/setup.py
Zipline: https://github.com/quantopian/zipline/blob/1.1.1/etc/requirements.txt

you may say: you don't need ZL with pyfolio.
Yes but when I'm trying to open a zipline result pickle file, if I don't have ZL Pyfolio is not able to unserialize the ZL Objects.

Am I doing something wrong?
Any suggestion?

@twiecki
Copy link
Contributor

twiecki commented Sep 11, 2017

@bonesmccoy Hm, that's indeed a pickle (no pun intended). The empyrical version mismatch should be fixed easily, the pandas one might be more tricky. CC @richafrank

@twiecki
Copy link
Contributor

twiecki commented Sep 11, 2017

We can probalby make pyfolio pandas 0.18.1 compat without too much effort (if it isn't already).

@richafrank
Copy link
Member

Yup, we'll be fixing the pandas issue soon, unless you get to it first.

zipline doesn't read the reqs.txt literally and actually supports empyrical>=2.2, so I don't think that's an issue here, unless you specifically want to use empyrical<0.3.2.

@eigenfoo
Copy link
Contributor Author

Closed by #552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants