-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple Tearsheet #389
Simple Tearsheet #389
Conversation
Very cool! We talked about this before so great to see it realized here. Travis is broken due to pandas-datareader, so that's unrelated. Can you add a simple test to https://github.com/quantopian/pyfolio/blob/master/pyfolio/tests/test_tears.py? |
…mple_position_tear_sheet for easier use
I added tests for all simple_tearsheet functions, but since Travis is broken I'm not sure if its working. I also touched up the code so it follows flake8 and takes in fewer parameters than the full_tearsheet functions, so its much easier to use. @twiecki @gusgordon @Jstauth @adeychman thoughts and feedback? |
Looks great to me. Here are my suggestions:
Another thought is that we could have only one |
on Gus's suggestions here are my thoughts:
I agree that plot as is isn't wildly useful, however as this is its the only plot that give you a sense of the position concentration and top N names, which is often a pretty useful first order thing to see about an algo. So until/unless we could replace it with something that gets to that info I'd be inclined to leave it in. As for things to add, maybe the transaction times distribution? |
Took on board Jess's comments; the top 10 holdings plot is back in (along with a list of top 10 names). Also, I've integrated all Unfortunately, the table in the beginning isn't so easily put into that same jpg. |
Final edits done; waiting on green light from @twiecki to merge. |
NB: I inferred what the correct URL would be for the png images; they will not show images because I am not working on a branch of quantopian, but a branch of georgh0021
This looks great! I think we should add this to the tutorial as well. Either as a separate one, or under http://quantopian.github.io/pyfolio/notebooks/zipline_algo_example/. |
@twiecki The plan is to add the tutorial when George adds his factor tear sheet (which he's working on next), so merging this now. |
Added functions to create a simple tearsheet with only essential plots. Useful for beginners and people who just want a quick overview/basic visualization of their backtest.
Example simple tearsheet attached (using nonsense data).