Slippage sweep #170
Closed
Slippage sweep #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, nice addition @acampbell22! |
|
@humdings can you help review this? |
| turnover = txn.get_turnover(transactions, positions, | ||
| period=None, average=False) | ||
| if slippage_params is None: | ||
| slippage_params = [3, 8, 10, 12, 15, 20, 50] |
There was a problem hiding this comment.
I'd put this into a tuple and add it to the default kwargs above.
a-campbell
force-pushed
the
slippage-sweep
branch
from
5021782 to
f2eef22
Compare
…t for slippage adjustement in all full tearsheet plots. STY Moved turnover to txn.py. Moved transactions related tests to separate file
a-campbell
force-pushed
the
slippage-sweep
branch
from
7cbd3b2 to
42a5309
Compare
| Timeseries of portfolio returns to be adjusted for various | ||
| degrees of slippage. | ||
| transactions : pd.DataFrame | ||
| Daily transaction volume and dollar ammount. |
|
Merged with 07e40a5. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new function to add slippage to returns time series. User can pass slippage-free returns and add slippage before generating plots and figures. If slippage is set, a plot of equity curves at different slippage assumptions will be generated. A plot of average annual returns at various levels of slippage will also be created.