Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vectorize max drawdown and fix doc strings #281

Merged
merged 3 commits into from
Feb 3, 2016

Conversation

devinstevenson
Copy link
Contributor

  • Vectorize max_drawdown for 4X speedup
  • Fix typos in doc strings
    model_returns_t and model_returns_normal had each other’s doc string


Compared with the normal model, this model assumes returns are
T-distributed and thus have a 3rd parameter (nu) that controls the
mass in the tails.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@twiecki
Copy link
Contributor

twiecki commented Feb 3, 2016

Thanks, that's great!

twiecki added a commit that referenced this pull request Feb 3, 2016
vectorize max drawdown and fix doc strings
@twiecki twiecki merged commit 73e91bc into quantopian:master Feb 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants