Refactor roundtrip #293
Merged
Refactor roundtrip #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiecki
force-pushed
the
refactor_roundtrip
branch
from
5f44b8b to
124cc0d
Compare
|
CC @a-campbell |
…n and does not require closing of positions.
…d one that has portfolio values to compute portfolio round-trip return.
twiecki
force-pushed
the
refactor_roundtrip
branch
from
124cc0d to
c88fb72
Compare
| ('Avg # round_trips per day', lambda x: float(len(x)) / | ||
| (x.max() - x.min()).days), | ||
| ('Avg # round_trips per month', lambda x: float(len(x)) / | ||
| (((x.max() - x.min()).days) / 21)), |
There was a problem hiding this comment.
could use utils.APPROX_BDAYS_PER_MONTH
twiecki
force-pushed
the
refactor_roundtrip
branch
from
6a17150 to
9ce08a0
Compare
| abs_amount = int(abs(t.amount)) | ||
| indiv_prices = [signed_price] * abs_amount | ||
| if (len(price_stack) == 0) or \ | ||
| (copysign(1, price_stack[-1]) == copysign(1, t.amount)): |
There was a problem hiding this comment.
would np.sign(price_stack[-1]) == np.sign(t.amount) work here?
There was a problem hiding this comment.
That's what I had initially but there was a huge overhead with calling numpy on a scalar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete rewrite of the round-trip analysis. Now does complete portfolio reconstruction based on transactions and matches orders even without crossing the zero-mark which should make it much more generally applicable. Also much better output.