Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates slick lib files #116

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

sbremer
Copy link

@sbremer sbremer commented Jun 29, 2017

I needed the frozenColumn feature from (https://github.com/ddomingues/X-SlickGrid) this fork of slick.

Please test before merging, I did some testing, yet my knowledge of proper JS testing is very limited.

After merging this change has to be reverted:

-REMOTE_URL = ("https://cdn.rawgit.com/quantopian/qgrid/"
+REMOTE_URL = ("https://cdn.rawgit.com/sbremer/qgrid/"

@TimShawver
Copy link
Contributor

Thanks for this. I'm going to be making some big changes to the way we load dependencies in qgrid so I think I'm going to merge those changes first before making a change like this. Somebody else wanted to use a different fork (https://github.com/6pac/SlickGrid) so I'm thinking probably what I should do is allow people to specify the name of the npm package they want to use for the slickgrid dependencies. This way people can use whatever fork they want to use.

For context, the branch I'm working on is here https://github.com/quantopian/qgrid/tree/widget-guidelines. It's still a work in progress but basically I'm moving to the suggested "best practices" for packaging/deploying widgets, which means getting slickgrid dependencies from npm. This should allow us to easily switch between the various slickgrid forks that are available on npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants