MAINT: Provides better error message when QUANDL_API_KEY isn't set #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llllllllll
reviewed
Jan 9, 2018
zipline/data/bundles/quandl.py
Outdated
| @@ -105,6 +106,14 @@ def fetch_data_table(api_key, | |||
| show_progress=show_progress, | |||
| ) | |||
|
|
|||
| except HTTPError as err: | |||
| if err.code == 400: | |||
There was a problem hiding this comment.
Can we just check this condition when we read the QUANDL_API_KEY out of the environment on line 210?
Quandl's new API for the WIKI Prices dataset requires an API key. Omitting the API key when running 'zipline ingest' would cause: HTTPError: HTTP Error 400: Bad Request QUANDL_API_KEY is now checked at the start of the ingestion process, and an error is raised if its value is 'None'.
ernestoeperez88
force-pushed
the
quandl_http_error
branch
from
2306006 to
63e58f4
Compare
|
lgtm, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quandl's new API for the WIKI Prices dataset requires an API key.
Omitting the API key when running 'zipline ingest' caused:
HTTPError: HTTP Error 400: Bad Request
The new message asks for QUANDL_API_KEY to be set before
running the ingest process again.