feat: return a uniform error interface #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matdurand
force-pushed
the
feat/uniform-error-interface
branch
from
3ee7995 to
f019a45
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
===========================================
- Coverage 100.00% 99.30% -0.70%
===========================================
Files 3 5 +2
Lines 296 286 -10
===========================================
- Hits 296 284 -12
- Misses 0 1 +1
- Partials 0 1 +1
☔ View full report in Codecov by Sentry. |
matdurand
force-pushed
the
feat/uniform-error-interface
branch
7 times, most recently
from
70cfd65 to
67503a6
Compare
In order to simplify the interface, the New and Wrap now return a standard `error`. Also, we fix the differences in frame skipping when using errors directly or the builder. This changes the interface quite a bit, so it's a major version bump.
matdurand
force-pushed
the
feat/uniform-error-interface
branch
from
67503a6 to
5dbc90e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify the interface, the New and Wrap now return a standard
error. Also, we fix the differences in frame skipping when using errors directly or the builder.This changes the interface quite a bit, so it's a major version bump.