Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add updated tox configuration #329

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Add updated tox configuration #329

merged 1 commit into from
Jun 5, 2023

Conversation

paddyroddy
Copy link
Collaborator

Fixes #245

@paddyroddy paddyroddy added the CI label Jun 2, 2023
@paddyroddy paddyroddy self-assigned this Jun 2, 2023
@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/quantumjot/btrack/329
Created: 2023-06-02T14:24:09.273478

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (64bfe5e) 85.63% compared to head (e34985a) 85.63%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   85.63%   85.63%           
=======================================
  Files          30       30           
  Lines        1956     1956           
  Branches      296      296           
=======================================
  Hits         1675     1675           
  Misses        201      201           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@paddyroddy paddyroddy marked this pull request as ready for review June 2, 2023 14:32
@alessandrofelder
Copy link
Collaborator

The issue #245 says we are currently "pinning to tox version 3" and we'd like to move to tox version 4. I can't find the line where this happens in this PR's diff. Is this moving to the new version implied by the changes to pyproject.toml, @paddyroddy ? (Just so I can learn :) )

@paddyroddy
Copy link
Collaborator Author

#245 was referring to a time before this commit d71cf97

Copy link
Collaborator

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM then.

@paddyroddy paddyroddy merged commit 5ba175c into main Jun 5, 2023
@paddyroddy paddyroddy deleted the fix-issue-245 branch June 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update tox configuration
3 participants