Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move fixtures into conftest.py #331

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Move fixtures into conftest.py #331

merged 7 commits into from
Aug 7, 2023

Conversation

paddyroddy
Copy link
Collaborator

@paddyroddy paddyroddy commented Jun 2, 2023

Fixes #288

@paddyroddy paddyroddy self-assigned this Jun 2, 2023
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Jun 2, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/quantumjot/btrack/331
Updated: 2023-08-07T15:47:16.128172

@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (44a1187) 86.00% compared to head (86482ed) 86.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   86.00%   86.00%           
=======================================
  Files          30       30           
  Lines        2165     2165           
  Branches      393      393           
=======================================
  Hits         1862     1862           
  Misses        223      223           
  Partials       80       80           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paddyroddy paddyroddy marked this pull request as ready for review August 7, 2023 15:44
@paddyroddy paddyroddy requested a review from quantumjot August 7, 2023 15:44
Copy link
Owner

@quantumjot quantumjot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@paddyroddy paddyroddy merged commit 99301cc into main Aug 7, 2023
@paddyroddy paddyroddy deleted the fix-issue-288 branch August 7, 2023 16:18
p-j-smith pushed a commit that referenced this pull request Aug 8, 2023
* Move `fixture`s into `conftest.py`

* Just import `btrack`

* Move `Container`

* Fix tests

* Rename writer

* Use `qtpy`
p-j-smith added a commit that referenced this pull request Aug 8, 2023
* Update plugin reader to return early for unsupported filetypes

* Add a function btrack.utils.napari_to_tracks

Converts napari layer data into a list of Tracklets

* Add hdf writer function to the plugin

* Add plugin writer to napari config

* Use empty dict for graph and properties if they are not layer metadata

* Determine parent, root, and children from graph if it exists

* Make black happy

* Add the tracks.h5 example dataset

* Set correct parent, root, and generation when converting napari to track

* Add test for btrack.utils.napari_to_tracks

The z-coordinates are not compared as dummy objects in the sample set have non-zero values even though it's a 2D dataset

* Use constants.States enum when setting default label rather int literal

Also inherit from enum.IntEnum for constants.States otherwise numpy complains that it can't be used to set as a fill value with np.full_like

* Upgrade `cvxopt` (#348)

* Update `pre-commit` and make some other fixes

* Update version pins

* Remove references to `cvxopt`

* Add type

Co-authored-by: Alan R Lowe <code@arlowe.co.uk>

* Use `|=`

* Remove extra dependencies

---------

Co-authored-by: Alan R Lowe <code@arlowe.co.uk>

* Move `fixture`s into `conftest.py` (#331)

* Move `fixture`s into `conftest.py`

* Just import `btrack`

* Move `Container`

* Fix tests

* Rename writer

* Use `qtpy`

* Don't set widget values in the widgets (as done from file)  (#379)

* Remove unnecessary `.setValue` calls

* Check status done by config file

* Don't store refs when converting tracks to napari

* Fix description of return values from napari_to_tracks

---------

Co-authored-by: Patrick Roddy <patrickjamesroddy@gmail.com>
Co-authored-by: Alan R Lowe <code@arlowe.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add conftest.py and use the builtin tmp_path fixture
3 participants