Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hypotheses boxes to QListWidget to reduce space #363

Merged
merged 12 commits into from
Aug 4, 2023

Conversation

paddyroddy
Copy link
Collaborator

The current QCheckBox takes up a lot of space.

  • Before
    image

  • Looks like
    image

  • Problem if you click config name from cellparticlecell removes all ticks
    image

  • P_FP should be enabled always. Not sure if this setting exists
    image

@paddyroddy paddyroddy self-assigned this Aug 3, 2023
btrack/napari/constants.py Outdated Show resolved Hide resolved
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Aug 3, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/quantumjot/btrack/363
Updated: 2023-08-04T13:59:06.464517

btrack/napari/sync.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2023

Codecov Report

Patch coverage: 92.00% and project coverage change: -0.34% ⚠️

Comparison is base (f285d36) 86.10% compared to head (9855062) 85.77%.
Report is 20 commits behind head on main.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   86.10%   85.77%   -0.34%     
==========================================
  Files          30       30              
  Lines        2109     2151      +42     
  Branches      392      394       +2     
==========================================
+ Hits         1816     1845      +29     
- Misses        213      225      +12     
- Partials       80       81       +1     
Files Changed Coverage Δ
btrack/io/_localization.py 90.43% <ø> (-1.53%) ⬇️
btrack/io/exporters.py 72.22% <ø> (ø)
btrack/io/hdf.py 76.42% <0.00%> (ø)
btrack/napari/config.py 86.11% <0.00%> (ø)
btrack/napari/widgets/create_ui.py 100.00% <ø> (+1.25%) ⬆️
btrack/btypes.py 82.54% <100.00%> (ø)
btrack/napari/sync.py 94.11% <100.00%> (+0.36%) ⬆️
btrack/napari/widgets/_general.py 100.00% <100.00%> (ø)
btrack/napari/widgets/_hypothesis.py 100.00% <100.00%> (ø)
btrack/napari/widgets/_motion.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paddyroddy
Copy link
Collaborator Author

All working now
image

@paddyroddy paddyroddy requested a review from p-j-smith August 4, 2023 13:53
@paddyroddy paddyroddy marked this pull request as ready for review August 4, 2023 13:53
@@ -353,7 +353,7 @@ class Tracklet:
x values.
"""

def __init__(
def __init__( # noqa: PLR0913
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering what these new ruff rules are?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is complaining about too many arguments. I updated ruff a bit but not all the way as there was more to fix.

Copy link
Collaborator

@p-j-smith p-j-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@paddyroddy paddyroddy merged commit 7d6bb9d into main Aug 4, 2023
@paddyroddy paddyroddy deleted the shrink-spacing-checkboxes-hypothesis branch August 4, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants