Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from cirq-dev pypi package to cirq-unstable pypi package #2431

Closed
Strilanc opened this issue Oct 29, 2019 · 4 comments · Fixed by #2444
Closed

Switch from cirq-dev pypi package to cirq-unstable pypi package #2431

Strilanc opened this issue Oct 29, 2019 · 4 comments · Fixed by #2444

Comments

@Strilanc
Copy link
Contributor

Strilanc commented Oct 29, 2019

I think this is less confusing in important ways. Opinions?

@mpharrigan
@dabacon
@maffoo
@cduck

@dabacon
Copy link
Collaborator

dabacon commented Oct 29, 2019

SGTM

@maffoo
Copy link
Contributor

maffoo commented Oct 29, 2019

@Strilanc, can you describe the confusion you're hoping to prevent? I'm not tied to the name cirq-dev, just want to make sure I understand the thinking here and that we pick a different name that avoids the problems you see.

Another thing that I'd like to at least explore before we do this is whether it's possible to prevent pip from installing both cirq and cirq-whatever in the same virtualenv, since currently this is possible and leads to weird failures (see #2347). For people who now have cirq-dev installed, the same issue will come up if we switch to cirq-unstable, so if there's a way to fix this that would ease the transition.

@Strilanc
Copy link
Contributor Author

can you describe the confusion you're hoping to prevent?

We have the package variant cirq[dev-env], which installs a developer environment.
We have the alternate package cirq-dev, which installs the latest version of cirq from master.

They both use the word "dev" in a packaging context as a suffix to cirq, but it means drastically different things in each case.

@Strilanc
Copy link
Contributor Author

Another thing that I'd like to at least explore before we do this is whether it's possible to prevent pip from installing both cirq and cirq-whatever in the same virtualenv, since currently this is possible and leads to weird failures

The same thing happens with tensorflow and tf-nightly

mkvirtualenv breakage --python=/usr/bin/python3
pip install tf-nightly
python -c "import tensorflow"  # works
pip install tensorflow
pip uninstall tensorflow
python -c "import tensorflow"  # blows up
pip install tf-nightly
python -c "import tensorflow"  # blows up

Strilanc added a commit that referenced this issue Oct 29, 2019
- Refactor verify-published-package to have an --unstable flag.
- Refactor verify-published-package to require --prod/--test/--unstable be specified
- Rename various CIRQ_DEV type things to CIRQ_UNSTABLE type things

Fixes #2431
CirqBot pushed a commit that referenced this issue Oct 30, 2019
- Refactor verify-published-package to have an --unstable flag.
- Refactor verify-published-package to require --prod/--test/--unstable be specified
- Rename various CIRQ_DEV type things to CIRQ_UNSTABLE type things

Fixes #2431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants