Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to ubuntu-latest in Github Actions #4136

Closed
balopat opened this issue May 26, 2021 · 3 comments · Fixed by #4148
Closed

Switch to ubuntu-latest in Github Actions #4136

balopat opened this issue May 26, 2021 · 3 comments · Fixed by #4148
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@balopat
Copy link
Contributor

balopat commented May 26, 2021

Description of the issue

The ubuntu-16.04 environment is deprecated and will be removed on September 20, 2021. We need to migrate to ubuntu-latest instead. For more details see actions/runner-images#3287.
@balopat balopat added the kind/health For CI/testing/release process/refactoring/technical debt items label May 26, 2021
@stubbi
Copy link
Contributor

stubbi commented May 26, 2021

@balopat is there a reason you propose ubuntu-latest instead of ubuntu-18.04? I think specific version tags are generally preferable.

@balopat
Copy link
Contributor Author

balopat commented May 27, 2021

I just copy pasted the warning ;) I'm okay with 18.04!

@stubbi
Copy link
Contributor

stubbi commented May 28, 2021 •
edited
Loading

@balopat alright!

I noticed there is even ubuntu-20.04 available. Please, have a look at #4148 where I made the change. I had to adapt the bazel install. Also set the 2019 version tag for windows instead of latest.

@stubbi stubbi mentioned this issue May 28, 2021
Merged
3 tasks
CirqBot pushed a commit that referenced this issue Jun 7, 2021
@stubbi
GH actions ubuntu 20 04 (#4148)
8e7e302 
resolves #4136. Includes

* [x] changes `ubuntu-16.04` to `ubuntu-20.04`
* [x] [updated bazel install](https://gist.github.com/diegopacheco/10f4d7be75574e53e91c49f19bf2613f) for Ubuntu 20.04
* [x] sets specific version tag for windows
rht pushed a commit to rht/Cirq that referenced this issue May 1, 2023
@stubbi @rht
GH actions ubuntu 20 04 (quantumlib#4148)
336bb8d 
resolves quantumlib#4136. Includes

* [x] changes `ubuntu-16.04` to `ubuntu-20.04`
* [x] [updated bazel install](https://gist.github.com/diegopacheco/10f4d7be75574e53e91c49f19bf2613f) for Ubuntu 20.04
* [x] sets specific version tag for windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH actions ubuntu 20 04 stubbi/Cirq
2 participants
@balopat @stubbi