-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update protobuf version #2239
Update protobuf version #2239
Conversation
We should also update the protobuf version in |
Thank you for the comments. I had indeed used I find that the bazel machinery in master is actually not functional, I am working on remedying this. |
I think we used to check that the bazel build worked, but then it kept breaking for reasons out of our control (e.g. the link where the protobuf installer was located stopped working) so I removed the check. If you can get it working consistently, that would be awesome. |
Made some further changes to address your comments:
|
This looks good to me. @maffoo you agree? If so automerge it. |
Resolves #2238