Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JSON serialization for numpy dtypes #2456

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Implement JSON serialization for numpy dtypes #2456

merged 2 commits into from
Oct 30, 2019

Conversation

kevinsung
Copy link
Collaborator

@kevinsung kevinsung commented Oct 30, 2019 •
edited
Loading

Fixes #2453

@kevinsung kevinsung requested a review from mpharrigan October 30, 2019 21:42
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Oct 30, 2019
mpharrigan
mpharrigan approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also consider using x.item()

@kevinsung kevinsung added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Oct 30, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Oct 30, 2019
@CirqBot CirqBot merged commit d3cfe3f into quantumlib:master Oct 30, 2019
@CirqBot CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Oct 30, 2019
@kevinsung kevinsung deleted the numpy_json branch October 31, 2019 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpharrigan mpharrigan mpharrigan approved these changes

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Numpy types other than float64 and complex128 are not JSON serializable
4 participants
@kevinsung @mpharrigan @googlebot @CirqBot